Re: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

Hi Philippe, On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:23 +0100 > From: Philippe Mathieu-Daudé <philmd(a)linaro.org&gt; > Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace > PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE > X-Mailer: git-send-email 2.41.0 [snip] > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 27e04c52f6..f01a30d3d9 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -256,6 +256,16 @@ GlobalProperty pc_compat_2_4[] = { > }; > const size_t pc_compat_2_4_len = G_N_ELEMENTS(pc_compat_2_4); > > +/* > + * @PC_ACPI_DATA_SIZE: > + * Size of the chunk of memory at the top of RAM for the BIOS ACPI tables > + * and other BIOS datastructures. > + * > + * BIOS ACPI tables: 128K. Other BIOS datastructures: less than 4K > + * reported to be used at the moment, 32K should be enough for a while. > + */ > +#define PC_ACPI_DATA_SIZE (0x20000 + 0x8000) > + What about putting this in pc.h? Because it is a general definition for PC.

Others are good for me, Reviewed-by: Zhao Liu <zhao1.liu(a)intel.com&gt;