Re: [libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script
On Wed, 2020-04-08 at 12:42 +0200, Erik Skultety wrote:
On Wed, Apr 08, 2020 at 11:49:45AM +0200, Andrea Bolognani wrote:
> On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> > - extra_vars = json.dumps({
> > + extra_vars_d = {
>
> You don't really need to change the name of the variable.
Right, although there are certain good practices like adding _l to lists and _d
to dicts, so that it's immediately visible what kind of object you're working
with when you don't have the initialization of the object right in front of
your eyes.
I wasn't aware of these good practices, but either way we're not
currently using them in lcitool so adopting them in a single case
out of a thousand lines of code doesn't make a lot of sense to me.
--
Andrea Bolognani / Red Hat / Virtualization