On Tue, Mar 18, 2014 at 07:12:03AM +0000, qiaonuohan(a)cn.fujitsu.com wrote:
This patch adds "[--compression-format] <string>" to
"virsh dump --memory-only",
which is changed to use the new virDomainCoreDumpWithFormat API. And
"--compress" is added as an alias for "--compression-format zlib".
Signed-off-by: Qiao Nuohan <qiaonuohan(a)cn.fujitsu.com>
---
tools/virsh-domain.c | 45 ++++++++++++++++++++++++++++++++++++++++++---
tools/virsh.pod | 5 +++++
2 files changed, 47 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1d3c5f0..f7e2226 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -4486,6 +4486,14 @@ static const vshCmdOptDef opts_dump[] = {
.type = VSH_OT_BOOL,
.help = N_("dump domain's memory only")
},
+ {.name = "compress",
+ .type = VSH_OT_ALIAS,
+ .help = "compression-format=zlib",
+ },
This name is ok, but...
+ {.name = "compression-format",
+ .type = VSH_OT_DATA,
+ .help = N_("specify the compression format of kdump-compressed format")
+ },
...I actually think this second arg should just be called 'format'
since not all formats imply compression.
Regards,
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|