Re: [libvirt] [PATCH v2] Allow comma separated list of shutdown/reboot modes with virsh
On Fri, Nov 30, 2012 at 02:28:53PM -0500, Eric Blake wrote:
> > From: "Daniel P. Berrange" <berrange(a)redhat.com>
> >
> > The shutdown and reboot commands in virsh allow a comma
> > separated list of mode values
> >
> > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> > ---
> > tools/virsh-domain.c | 25 +++++++++++++++++++++++--
> > tools/virsh.pod | 16 ++++++++++++----
> > 2 files changed, 35 insertions(+), 6 deletions(-)
>
> Conditional ACK, if you squash in the hunk that got misplaced
> in your duration==0 patch.
Opps, yes, rebase mistake. Will fix when pushing
Well, we still have some sort of rebase mistake; 'git bisect'
pointed to this commit as the culprit.
./virsh-undefine: line 62: 24499 Segmentation fault (core dumped)
$abs_top_builddir/tools/virsh -q -c test:///default 'shutdown test; undefine test;
dominfo test' > out 2>&1
--- expout 2012-11-30 13:43:00.894996356 -0700
+++ out 2012-11-30 13:43:00.747996489 -0700
@@ -1,4 +0,0 @@
-Domain test is being shutdown
-Domain test has been undefined
-error: failed to get domain 'test'
-error: Domain not found
FAIL: virsh-undefine
I'm still looking into it.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org