Re: [libvirt] [PATCH v2 7/9] admin: Add support for connection close callbacks

...

#undef DECLARE_CLASS_COMMON #undef DECLARE_CLASS_LOCKABLE @@ -822,6 +825,9 @@ virAdmConnectNew(void) if (!(ret = virObjectLockableNew(virAdmConnectClass))) return NULL;

+ if (!(ret->closeCallback = virObjectLockableNew(virAdmConnectCloseCallbackDataClass))) + return NULL; +

You'll need to free ret or have some sort of cleanup here.

John

Unlike 6/7, I haven't noticed this one, so again, thanks :). Erik