On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido Günther wrote:
Hi, having JUnit like XML allows for easy integration into CI tools like Jenkins. Attach patch adds this using TAP::Formatter::JUnit. Does this look reasonable?
Do we need to modify a spec file to pull in the TAP::Formatter::JUnit module when installing the tck on Fedora? Other than that, it seems reasonable to me, but I'd also like Dan's feedback.
Normally you don't need to add Perl modules to the SPEC because RPM will autodetect them, but because of the way the TAP system works, we *do* need to add any TAP::Formatter::* modules manually. So ACK if you add this as a Requires and BuildRequires in the RPM perl-Sys-Virt-TCK.spec.PL Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|