Re: [libvirt] [PATCH console-proxy 0/6] libvirt-go-xml and libvirt-console-proxy ?

Hello Daniel, I regularly visit your blog and stumbled over <https://www.berrange.com/posts/2017/01/05/announce-new-libvirt-project-go...;, which seems to contains some small errors - I'm a "go"-newby, so I had to spend some time to understand your example and to make it go: > import ( > libvirt "github.com/libvirt/libvirt-go" > libvirtxml "github.com/libvirt/libvirt-go-xml" > "encoding/xml" > "fmt" > ) > > conn, err := libvirt.NewConnect("qemu:///system") > dom := conn.LookupDomainByName("demo") This also returns a tuple (dom, err), so should look like: dom, err := conn.LookupDomainByName("demo") > xmldoc, err := dom.GetXMLDesc(0) > > domcfg := &libvirtxml.Domain{} > err := xml.Unmarshal([]byte(xmldocC), domcfg) This fails as "err" is already defined. Should be '=' instead of ':=': err = xml.Unmarshal([]byte(xmldocC), domcfg) > > fmt.Printf("Virt type %s", domcfg.Type) Maybe add an "\n" at the end? And maybe also add the wrapper > package main ... > func main() { ... > } to make the example complete?

Second is <https://www.berrange.com/posts/2017/01/26/announce-new-libvirt-console-pr...;: Do you (or someone else) still work on libvirt-console-proxy? It no longer compiles after several API changed in libvirt-go-xml and uuid. I have attached several patches, which at least allow compiling again, I only tested is briefly.