Re: [libvirt] [PATCH 13/22] qemu: monitor: Change fields in qemuBlockStats to 'unsigned'

On Thu, Sep 19, 2019 at 07:13:16PM +0200, Peter Krempa wrote:

None of the fields actually return negative values. The internal implementation of BlockAcctStats struct in qemu uses uint64_t and the last place using -1 in libvirt was in the HMP monitor code which was deleted.

Change the internal type to unsigned long long and ensure that all public conversions don't overflow.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/qemu/qemu_driver.c | 35 ++++++++++++++++++++++------------- src/qemu/qemu_monitor.h | 16 ++++++++-------- src/qemu/qemu_monitor_json.c | 2 +- 3 files changed, 31 insertions(+), 22 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano