Re: [PATCH v2 13/27] network: framework to call backend-specific function to init private filter chains

23 Apr 2024


      On 4/23/24 6:21 AM, Daniel P. Berrangé wrote:
...
On Sun, Apr 21, 2024 at 10:53:21PM -0400, Laine Stump wrote:
...
[...]
+static int
+networkFirewallSetupPrivateChains(virFirewallBackend backend,
+                                  virFirewallLayer layer)
+{
+    switch (backend) {
+    case VIR_FIREWALL_BACKEND_IPTABLES:
+        return iptablesSetupPrivateChains(layer);
+
+    case VIR_FIREWALL_BACKEND_UNSET:
+    case VIR_FIREWALL_BACKEND_LAST:
+        networkFirewallBackendUnsetError();
for _LAST and default: cases, you should use
virReportEnumRangeError(virFirewallBackend, backend)
Right, I forgot about that.
...
...
+        return -1;
+    }
+    return 0;
+}
+
With regards,
Daniel