Re: [libvirt] [RFC 7/7] tools: Force virsh to use deprecated features

On Tue, Oct 02, 2018 at 16:14:46 +0200, Andrea Bolognani wrote: > Instead of trying newer APIs first and only falling back to > deprecated ones if those are not available, go straight for > the older APIs. > > Running 'virsh list' will now cause warnings to be displayed. > > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; > --- > tools/virsh-domain-monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c > index 3a2636377d..f2f2944a8a 100644 > --- a/tools/virsh-domain-monitor.c > +++ b/tools/virsh-domain-monitor.c > @@ -1609,6 +1609,8 @@ virshDomainListCollect(vshControl *ctl, unsigned int flags) > int mansave; > virshControlPtr priv = ctl->privData; > > + goto fallback; Obvious NACK since you did not make the patch look as a reproducer case to prove the code changes work. I suggest adding a all-caps warning to the subject and NOT adding a Sign-off for reproducers not meant to be pushed.