Re: [libvirt] [PATCH 0/7] qemu: Job handling fixes

On 01/22/2015 10:20 AM, Peter Krempa wrote: > While reviewing Martin's reference counting series I've noticed a few qemu API > impls that don't properly handle jobs. > > Peter Krempa (7): > qemu: Fix job handling in qemuDomainPinVcpuFlags > qemu: Fix job handling in qemuDomainPinEmulator > qemu: Fix job handling in qemuDomainSetAutostart > qemu: Fix job handling in qemuDomainSetMemoryParameters > qemu: Fix job handling in qemuDomainSetSchedulerParametersFlags > qemu: Fix job type in qemuDomainGetBlockIoTune > qemu: Fix job handling in qemuDomainSetMetadata > > src/qemu/qemu_driver.c | 135 +++++++++++++++++++++++++++++++------------------ > 1 file changed, 87 insertions(+), 48 deletions(-) > In patches 1-3,5 it's necessary to check if the domain is still alive after getting the job. I suggest moving the BeginJob between the ACL check and virDomainLiveConfigHelperMethod, which does check for domain liveness. ACK with that fix.