Re: [PATCH V4 06/11] spec: Move common files and dependencies to libvirt-daemon-common

On Thu, Dec 22, 2022 at 11:03:37AM -0700, Jim Fehlig wrote: > -Requires: polkit >= 0.112 > %if %{with_dmidecode} > # For virConnectGetSysinfo > Requires: dmidecode > %endif > # For service management > Requires(post): /usr/bin/systemctl > -%if %{with_numad} > -Requires: numad > -%endif > -# libvirtd depends on 'messagebus' service > -Requires: dbus > -# For uid creation during pre > -Requires(pre): shadow-utils > +Requires: polkit >= 0.112 > # Needed by /usr/libexec/libvirt-guests.sh script. > %if 0%{?fedora} >= 37 > Requires: gettext-runtime > %else > Requires: gettext > %endif > +# libvirtd depends on 'messagebus' service > +Requires: dbus > +# For uid creation during pre > +Requires(pre): shadow-utils This looks like pure noise - AFAICT you could have left the requires for polkit, dbus and shadow-utils exactly where they already were. Is there a reason why you moved them?