Re: [libvirt] [PATCH 1/2] lxc: add support for docker-json Memory and VCPU conversion
On Fri, Jun 16, 2017 at 05:49:54PM +0200, Cedric Bosdonnat wrote:
Quick note: next time you send a patch series, add a cover letter to
it.
You can get git to automatically ask you about one by running
git config add format.coverletter auto
Having reviewed them off-list first, ACK from me to those changes.
Daniel, do you want to double-review them?
Functionally it looks fine - just had some comments about style / layout
and naming conventions.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|