Re: [libvirt] [PATCH RFC 10/39] qemu: process: clear QEMU_CAPS_BLOCKDEV for VMs where we can't support it
On Wed, Jul 25, 2018 at 05:57:41PM +0200, Peter Krempa wrote:
SD cards are currently passed by using -drive only which would not be
compatible with using -blockdev fully.
Floppies at least in the case of the i440 machine type don't have a
reasonable qdev ID if -drive is not used and thus would not allow
queries and other operations. Since floppy drives are obsolete anyways
clear blockdev when using them.
Clear QEMU_CAPS_BLOCKDEV if the VM has such devices.
Do you see any value in mentioning that this gets recorded in the status
XML?
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_process.c | 10 ++++++++++
1 file changed, 10 insertions(+)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)