Re: [libvirt] [PATCH 05/20] Secret manipulation step 5: RPC client
----- "Daniel Veillard" <veillard(a)redhat.com> wrote:
On Sun, Aug 16, 2009 at 10:47:58PM +0200, Miloslav Trmač wrote:
> +static virDrvOpenStatus
> +remoteSecretOpen (virConnectPtr conn,
> + virConnectAuthPtr auth,
> + int flags)
> +{
> + if (inside_daemon)
> + return VIR_DRV_OPEN_DECLINED;
> +
> + if (conn &&
> + conn->driver &&
> + STREQ (conn->driver->name, "remote")) {
> + struct private_data *priv;
> +
> + /* If we're here, the remote driver is already
> + * in use due to a) a QEMU uri, or b) a remote
> + * URI. So we can re-use existing connection
> + */
Hum, is that comment right ? We are certainly using a remote URI in
any case there, isn't it ?
The same comment is in in all of the other
"subdriver" remote...Open () routines. It's not quite clear what
"remote" means where, as far as I can see "remote" means an
"explicitly remote" URL, e.g. anything+tls://hostname/..., and "QEMU"
means "qemu://hostname/..." (rejected by qemu_driver).
Mirek