On 06/06/2014 04:54 PM, Laine Stump wrote:
Patches 1/3 and 2/3 are prerequisites the the patch that started
this
thread. Patch 3/3 should be squashed into the original patch.
I also noticed that the original patch causes all unrecognized
"-device" options to now be ignored rather than being added to the
qemu namespace (with a warning). This needs to be fixed before
resubmitting that patch too, but I didn't have the time/interest to do
it.
(If needed/desired, all three of these new patches can be pushed
separately before the patch at the top of this thread).
Laine Stump (3):
test: display qemuParseCommandline warnings when VIR_TEST_DEBUG > 0
qemu: ignore -nodefconfig and -nodefaults in
qemuParseCommandLineString
test: make hostdev-vfio test able to pass qemuargv2xmltest
src/qemu/qemu_command.c | 4 +-
tests/qemuargv2xmltest.c | 45 ++++++++++++++++------
.../qemuxml2argvdata/qemuxml2argv-hostdev-vfio.xml | 1 +
3 files changed, 38 insertions(+), 12 deletions(-)
I pushed 1/3 and 2/3, and have sent another patch to add parsing for
<memballoon> (which is also required for all the tests to patch once the
original is done correctly). I left 3/3 to be squashed into the original
patch of the thread.
Thanks for the reviews!