Re: [libvirt] [RFC][PATCH] storage: allow alphabetical names in owner/group of permissions
On Mon, Mar 16, 2009 at 10:01:38AM +0100, Daniel Veillard wrote:
On Sun, Mar 15, 2009 at 02:47:14AM +0900, Ryota Ozaki wrote:
> Hi,
>
> This patch allows to specify owner/group of permissions in storage XML
> as alphabetical names.
>
> One concern of this patch is since alphabetical names are converted
> to uid/gid at XML parsing (e.g., virsh pool-define some-pool.xml),
> the generated XML file for libvirt internal does not contain the original
> alphabetical names and dumpxml does not as well. Is it better the
> conversion is done when activated not defined?
Yes, I'm wondering about this. Usually it's better if the XML
can round-trip without change (i.e. the exported version is the
same as the imported one), modulo maybe some reordering of elements.
But loosing information or distortions in the cycle tend to generate
problems. So I'm wondering what is in your opinion the added value
of having livirt do that conversion instead of the layer on top of
libvirt.
Yeah, I don't hugely like the idea of usernames turning into UIDs
when you round-trip the XML. Other places where we didn't correctly
preserve data on a round-trip have proved to be rather painful to
deal with for apps (eg, automatic VNC port number, or automatic
VIF names). I'm not sure what the right answer is for this problem
of uid vs username.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|