29 Jan
2021
29 Jan
'21
1:35 p.m.
On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote:
Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio options are absent. The old name was very misleading.
Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com> --- src/conf/domain_validate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
NACK to this patch. I don't see any point in this rename. The whole file mostly checks if something is missing. If anything I would go for virDomainVirtioOptionsValidate. Pavel