On 08/28/2018 09:58 AM, Michal Privoznik wrote:
On 08/28/2018 03:30 PM, John Ferlan wrote:
On 08/20/2018 08:09 AM, Michal Privoznik wrote:
In two places the passed pool object argument is marked as ATTRIBUTE_UNUSED even though it's used right away.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: John Ferlan <jferlan@redhat.com>
Although freeze hasn't been announced, an rc1 tag exists - so I'll state that although the first 2 patches could be designated safe for freeze, the rest of the series needs to wait until after 4.7.0.
Well, the whole patch set can be viewed as a bug fix and as such is exempt from freeze ;-)
Careful there you don't want to set a dangerous precedent, that I could use ;-)... Still, I see no bz associated with any patch in the series. Also there are three distinct things happening in this series. 1. Moving the Is/Find duplicate code into AssignDef for TOCTOU. That's a lot of moving parts and some amount of logic adjustment that should get more exposure than a few RC days. 2. The usage of in_use during download, upload, and wipe 3. Release of pool lock while in_use is set for more concurrency I think 2 is a "easy" bug, 1 is a "hard" bug, and 3 is less a bug and more a concurrency enhancement. When it comes to late in the game, trivial things (like patch 1), easy bugs, patches associated w/ customer bzs, and crash/core type bugs could/should be fixed. But harder to reproduce and/or present in more than the current (months) release can/should wait. Of course JMO... John