On Tue, Apr 14, 2009 at 04:40:46PM +0900, Takahashi Tomohiro wrote:
Hi Daniel-san,
Thank you for your reply.
virsh doesn't place any restrictions on whether those commands can be run on inactive guests. It should just try the API regardless and be prepared for any errors.
I see. I think that I should remove the following check from xend_internal.c PinVcpu method. Because the latest Xen supports this.
So, I made the patch that corrected the following problem. "virsh vcpupin" and "virsh vcpuinfo" can not be executed to inactive domains.
Sorry for the delay, I forgot about that patch !
If XenD supports this then it should be just a matter of removing the check from xend_internal.c PinVcpu method
if (domain->id < 0) { virXendError(domain->conn, VIR_ERR_INVALID_ARG, _("Domain %s isn't running."), domain->name); return(-1); }
Signed-off-by: Tomohiro Takahashi <takatom@jp.fujitsu.com>
Looks fine, we delegate to xend, and error return codes seems checked in both routines, So applied and commited to CVS, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/