
21 Mar
2011
21 Mar
'11
3:27 p.m.
On 03/19/2011 07:54 AM, Matthias Bolte wrote:
2011/3/18 Eric Blake <eblake@redhat.com>:
If virFileIsExecutable is to replace access(file,X_OK), then errno must be usable on failure.
* src/util/util.c (virFileIsExecutable): Set errno on failure. ---
ACK.
Thanks; pushed. Did you also get to look at patch 2 in the series, including the question of whether virFileIsExecutable should be checking access(file,R_OK|X_OK) for the purpose of executing shell scripts? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org