On Fri, Dec 01, 2023 at 11:58:05AM +0000, Daniel P. Berrangé wrote:
On Thu, Nov 30, 2023 at 08:29:55PM +0100, Andrea Bolognani wrote:
> The generator can produce different code on Linux and macOS:
> specifically, on the former we want to use xdr_uint64_t while
> the latter needs xdr_u_int64_t instead.
>
> This is clearly a problem for tests that involve comparing the
> output produced against some expected output that's stored in
> the git repository.
>
> In the long run, we need to find a better way to handle this,
> but since 9.10.0 is going to be released very soon and we don't
> want it to have a broken test suite on macOS, simply skip the
> generator tests on that platform for now.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> scripts/rpcgen/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Thanks. I've pushed all pending rpcgen-related patches, including
yours, since I had them neatly queued up already. We should be able
to go ahead with the release now :)
--
Andrea Bolognani / Red Hat / Virtualization