On Wed, Jan 30, 2013 at 08:16:59PM -0700, Eric Blake wrote:
On 01/30/2013 08:05 PM, Serge Hallyn wrote:
Without these two string changes in generator.py, the virGetLastError wrapper does not get created in /usr/share/pyshared/libvirt.py. Noticed when running tests with virt-install.
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com> --- python/generator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACK.
Bummer - that means the python bindings are broken in the 1.0.2 release.
I wonder if there's anything we could change in the generator to make this a fatal error in future, instead of silently dropped Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|