Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

Attached is an updated patch. The changes are: - updated to latest CVS - run make check / syntax-check - remove virsh subcommand (as per Dan's suggestion - see below) - some more things that Dan pointed out - see below I would like to add this to CVS because it is quite a pain tracking CVS changes. I know there's no remote support at the moment, but I can add that later.

+int virDomainBlockPeek (virDomainPtr dom, + const char *path, + unsigned long long offset, + size_t size, + void *buffer);

Index: tests/sexpr2xmldata/sexpr2xml-curmem.xml =================================================================== RCS file: /data/cvs/libvirt/tests/sexpr2xmldata/sexpr2xml-curmem.xml,v retrieving revision 1.6 diff -b -u -p -r1.6 sexpr2xml-curmem.xml --- tests/sexpr2xmldata/sexpr2xml-curmem.xml 8 May 2008 14:41:56 -0000 1.6 +++ tests/sexpr2xmldata/sexpr2xml-curmem.xml 4 Jun 2008 15:08:24 -0000 @@ -15,17 +15,17 @@ <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> + <disk type='file' device='disk'> + <driver name='tap' type='aio'/> + <source file='/xen/rhel5.img'/> + <target dev='xvda' bus='xen'/> + </disk> <interface type='bridge'> <source bridge='xenbr0'/> <target dev='vif5.0'/> <mac address='00:16:3e:1d:06:15'/> <script path='vif-bridge'/> </interface> - <disk type='file' device='disk'> - <driver name='tap' type='aio'/> - <source file='/xen/rhel5.img'/> - <target dev='xvda' bus='xen'/> - </disk> <input type='mouse' bus='xen'/> <graphics type='vnc' port='-1'/> <console type='pty'> Index: tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml =================================================================== RCS file: /data/cvs/libvirt/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml,v retrieving revision 1.10 diff -b -u -p -r1.10 sexpr2xml-no-source-cdrom.xml --- tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml 8 May 2008 14:41:56 -0000 1.10 +++ tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml 4 Jun 2008 15:08:25 -0000 @@ -20,11 +20,6 @@ <clock offset='utc'/> <devices> <emulator>/usr/lib/xen/bin/qemu-dm</emulator> - <interface type='bridge'> - <source bridge='xenbr0'/> - <target dev='vif6.0'/> - <mac address='00:16:3e:0a:7b:39'/> - </interface> <disk type='block' device='disk'> <driver name='phy'/> <source dev='/dev/sda8'/> @@ -34,6 +29,11 @@ <target dev='hdc' bus='ide'/> <readonly/> </disk> + <interface type='bridge'> + <source bridge='xenbr0'/> + <target dev='vif6.0'/> + <mac address='00:16:3e:0a:7b:39'/> + </interface> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='-1'/> <serial type='pty'>