[Libvir] Re: [PATCH] add no_tty flag for ssh

On Thu, Sep 20, 2007 at 01:10:28PM +0100, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: >> The use of '-o PasswordAuthentication=no' isn't sufficient because even >> with pulic key / gssapi auth schemes it may prompt for passwords and/or >> passphrases. >> >> I think we need to use '-T -o BatchMode=yes', and regardless of the >> no_tty flag I think it could be wise to add '-e none'. > Yes, that's right. Try this patch. There's something not quite right going on. It correctly prevents the prompting of passwords, but the '?' seems to be passed through to the remote end. So the server side tries to open 'qemu:///system?' and fails. Now technically '?' is a valid URI character and so qemu_driver.c should handle it, by parsing the URI properly, rather than STREQ(qemu:///system), but I think the client side should avoid appending the '?' too if there is no parameter to pass across.