Re: [PATCH v4 17/19] scripts: apibuild: parse 'Since' for functions
On Fri, Apr 22, 2022 at 09:23:42PM +0200, Victor Toso wrote:
+# The version in the .sym file might differnt from
+# the real version that the function was introduced.
+# This dict's value is the correct version, as it should
+# be in the docstrings.
Typo "differnt". I'll fix it before pushing.
+ # Simple way to avoid setting empty version
+ version_tag = len(since) > 0 and f" version='{since}'" or
""
Personally I'm not a fan of this Perl-y way of writing conditionals,
but as we already discussed the entire script badly needs an overhaul
so I'll leave it as is.
--
Andrea Bolognani / Red Hat / Virtualization