Re: [libvirt] [PATCH 00/14] Clean up spec files mess
On Tue, Jul 28, 2009 at 07:44:03PM +0100, Mark McLoughlin wrote:
The following series of patches pulls in the changes from
Fedora which make sense. Some of them I'm not 100% sure of:
- defaulting to policy kit - is there some reason we don't
want that upstream?
I'm not sure either
- The python cruft thing, not sure its needed
That's something I added while I was fighting with the build yesterday
%{version} and $(VERSION) were diverging leading to some nasty side
%effect I forgot to remove it there after. You landed in a Work In
Progress ...
- Converting NEWS to UTF-8 could probably be done upstream
Fix is trivial in news.xsl, yes
- Requiring libselinux is dubious, doesn't autorequires handle
that?
Yeah that should probably be dropped.
All other patches should be fine, except removal of spec file.
If you don't do this I will.
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/