Currently, domainJobInfo also uses "stats" as one of the job specific parameters. To remove this dependency, a privateData structure is introduced. The plan is to even have this structure renamed as `virDomainJobInfoInternal` as there already exists a `virDomainJobInfo'. On Tue, Jul 14, 2020 at 8:16 PM Michal Privoznik <mprivozn@redhat.com> wrote:
On 7/13/20 8:03 PM, Prathamesh Chavan wrote:
To remove dependecy of `qemuDomainJobInfo` on job specific paramters, a `privateData` pointer is introduced. To handle it, structure of callback functions is also introduced.
Signed-off-by: Prathamesh Chavan <pc44800@gmail.com> --- src/qemu/qemu_backup.c | 15 +++-- src/qemu/qemu_domain.h | 18 ++++++ src/qemu/qemu_domainjob.c | 98 +++++++++++++++++++++++++------- src/qemu/qemu_domainjob.h | 31 +++++----- src/qemu/qemu_driver.c | 18 +++--- src/qemu/qemu_migration.c | 14 +++-- src/qemu/qemu_migration_cookie.c | 7 ++- src/qemu/qemu_process.c | 11 +++- 8 files changed, 154 insertions(+), 58 deletions(-)
I'm not exactly sure why this is needed. Can you shed more light into it please?
Michal