Re: [libvirt] [PATCH] iscsi: do not fail to stop a stopped pool
On Wed, Apr 29, 2015 at 10:10:11AM -0400, John Ferlan wrote:
On 04/29/2015 09:08 AM, Ján Tomko wrote:
> Just as we allow stopping filesystem pools when they were unmounted
> externally, do not fail to stop an iscsi pool when someone else
> closed the session externally.
>
> Resolves:
> https://bugzilla.redhat.com/show_bug.cgi?id=1171984
For this I disagree - it doesn't resolve all the issues in 1171984.
I can remove the 'Resolves:' line.
It
resolves a symptom of libvirt allowing more than one pool to use the
same session.
This resolves the error to stop a pool when there's no pool anymore,
whether that's because someone called StopPool earlier on a pool that
was duplicate but libvirt didn't catch it, or manually via messing with
iscsiadm.
While there is disagreement over the method I've taken :
http://www.redhat.com/archives/libvir-list/2015-April/msg01197.html
Simply "covering up" the original issue by just ignoring the error on
stop doesn't seem to be the best solution to me.
The proposed series aims to detect duplicate pools on the same hosts.
It does not deal with duplicate pools on different hosts.
Even if we change the duplicate checks to only deal with the target,
as I suggested here:
https://www.redhat.com/archives/libvir-list/2015-April/msg00959.html
(since libvirt's iscsi backend treats the same target on different hosts
as a duplicate pool, but the check above does not), this patch also
fixes stopping the pool after someone messes with iscsiadm manually,
Jan
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)