On Tue, Jan 28, 2014 at 02:13:18PM +0100, Christophe Fergeau wrote:
Rather than the ever growing standalone libvirt-gconfig/tests/test-domain-create program, this commit adds support for glib GTester framework as well as 2 smaller tests cases for GVirConfigDomain and GVirConfigDomainClock. --- Makefile.am | 2 +- build-aux/glib-tap.mk | 135 ++++++ configure.ac | 3 + m4/glibtests.m4 | 28 ++ tap-driver.sh | 652 ++++++++++++++++++++++++++ tap-test | 5 + tests/Makefile.am | 18 + tests/test-gconfig.c | 674 +++++++++++++++++++++++++++ tests/xml/gconfig-domain-clock.xml | 7 + tests/xml/gconfig-domain-cpu.xml | 7 + tests/xml/gconfig-domain-device-channel.xml | 7 + tests/xml/gconfig-domain-device-console.xml | 5 + tests/xml/gconfig-domain-device-disk.xml | 9 + tests/xml/gconfig-domain-device-graphics.xml | 7 + tests/xml/gconfig-domain-device-input.xml | 5 + tests/xml/gconfig-domain-device-network.xml | 13 + tests/xml/gconfig-domain-device-sound.xml | 5 + tests/xml/gconfig-domain-device-usbredir.xml | 28 ++ tests/xml/gconfig-domain-device-video.xml | 7 + tests/xml/gconfig-domain-os.xml | 7 + tests/xml/gconfig-domain.xml | 15 + 21 files changed, 1638 insertions(+), 1 deletion(-) create mode 100644 build-aux/glib-tap.mk create mode 100644 m4/glibtests.m4 create mode 100755 tap-driver.sh create mode 100755 tap-test create mode 100644 tests/Makefile.am create mode 100644 tests/test-gconfig.c create mode 100644 tests/xml/gconfig-domain-clock.xml create mode 100644 tests/xml/gconfig-domain-cpu.xml create mode 100644 tests/xml/gconfig-domain-device-channel.xml create mode 100644 tests/xml/gconfig-domain-device-console.xml create mode 100644 tests/xml/gconfig-domain-device-disk.xml create mode 100644 tests/xml/gconfig-domain-device-graphics.xml create mode 100644 tests/xml/gconfig-domain-device-input.xml create mode 100644 tests/xml/gconfig-domain-device-network.xml create mode 100644 tests/xml/gconfig-domain-device-sound.xml create mode 100644 tests/xml/gconfig-domain-device-usbredir.xml create mode 100644 tests/xml/gconfig-domain-device-video.xml create mode 100644 tests/xml/gconfig-domain-os.xml create mode 100644 tests/xml/gconfig-domain.xml
Had a quick skim through and it looks decent. ACK assuming 'make check' passes ;-P Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|