On 2012年02月28日 01:30, Eric Blake wrote:
On 02/27/2012 04:58 AM, Osier Yang wrote:
* src/conf/domain_conf.h: Add new member "target" to struct _virDomainDeviceDriveAddress.
* src/conf/domain_conf.c: Parse and format "target"
* Lots of tests (.xml) in tests/domainsnapshotxml2xmlout, tests/qemuxml2argvdata, tests/qemuxml2xmloutdata, and tests/vmx2xmldata/ are modified for newly introduced attribute "target" for address of "drive" type. --- docs/formatdomain.html.in | 12 ++++++++++-- docs/schemas/domaincommon.rng | 10 ++++++++++ src/conf/domain_conf.c | 17 +++++++++++++---- src/conf/domain_conf.h | 1 + tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 12 ++++++------
This modifies existing tests, but I didn't (quickly) see any addition of a new test with a non-zero target.
tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml | 4 ++-- 194 files changed, 292 insertions(+), 264 deletions(-)
Evidence of my claim includes the fact that this patch did not add any new files, and none of the tests added more lines than were removed.
Yes, it's in 7/7, I wanted to add the .args and .xml files together in one patch.
@@ -2016,7 +2017,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf, return 0; }
- static int virDomainDevicePCIAddressParseXML(xmlNodePtr node, virDomainDevicePCIAddressPtr addr)
Spurious whitespace change, but I can live with it.
I'm okay if you add an 8/7 with further tests of the new XML (or, I may be surprised by 5-7/7 adding those tests).