Re: [libvirt] [PATCH 3/3] Fix race in finding available vnc port

On 05/20/2010 02:45 PM, Jim Fehlig wrote: > for (i = QEMU_VNC_PORT_MIN; i < QEMU_VNC_PORT_MAX; i++) { > int fd; > int reuse = 1; > struct sockaddr_in addr; > + bool used = false; > + > + virBitmapGetBit(driver->reservedVNCPorts, i - QEMU_VNC_PORT_MIN, &used); > For now, we're safe not checking for failure here. But maybe we should add an error check and a VIR_DEBUG to be proactive in case the size of driver->reservedVNCPorts is ever accidentally changed?