Re: [PATCH 02/33] qemu: monitor: Remove return value from qemuMonitorEmit* functions

The callers in the monitor code invoking the callbacks after events are received don't actually check the return value from the callbacks and there isn't really anything we could do on failure. Remove the return value from the intermediary functions so we can later remove them from the callback prototypes. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- src/qemu/qemu_monitor.c | 204 ++++++++++++---------------------------- src/qemu/qemu_monitor.h | 176 +++++++++++++++++----------------- 2 files changed, 150 insertions(+), 230 deletions(-)

diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 265c25c521..2fa5151652 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h -int qemuMonitorEmitTrayChange(qemuMonitor *mon, - const char *devAlias, - const char *devid, - int reason); -int qemuMonitorEmitPMWakeup(qemuMonitor *mon); -int qemuMonitorEmitPMSuspend(qemuMonitor *mon); -int qemuMonitorEmitBlockJob(qemuMonitor *mon, + void qemuMonitorEmitEvent(qemuMonitor *mon, const char *event, + long long seconds, unsigned int micros, + const char *details);

+void qemuMonitorEmitShutdown(qemuMonitor *mon, virTristateBool guest); +void qemuMonitorEmitReset(qemuMonitor *mon); +void qemuMonitorEmitStop(qemuMonitor *mon); +void qemuMonitorEmitResume(qemuMonitor *mon); +void qemuMonitorEmitRTCChange(qemuMonitor *mon, long long offset); +void qemuMonitorEmitWatchdog(qemuMonitor *mon, int action);