Re: [libvirt] [PATCH] virtperf: Revert PERF_COUNT_HW_REF_CPU_CYCLES conditional

On Tue, Mar 14, 2017 at 08:55:30AM +0000, Olaf Hering wrote: Well, it *reverts* that commit. If that is desired, it should rather be reverted with git-revert(1). However without that commit we'll be back to broken code that won't compile on some distros. So unless I missed something (if I did, it should be added to the commit message), there should rather be a configure check that defines something similar to other code, e.g. HAVE_PERF_CPU_CYCLES and then that should be used in the conditional. Anyway it looks like the code is wrong anyway, does it currently error out for you with "unable to open host cpu perf event ..." even though it should work? @Daniel: It seems like you probably wanted to relax the following condition in virPerfEventEnable(): if (event_attr->attrType == 0 && (type == VIR_PERF_EVENT_CMT || type == VIR_PERF_EVENT_MBMT || type == VIR_PERF_EVENT_MBML)) { am I right?