On 01/10/2011 01:45 PM, Eric Blake wrote:
On 01/10/2011 10:38 AM, Cole Robinson wrote:
One functionality change here is that we no longer force enable the event timeout for every queued event, only enable it for the first event after the queue has been flushed. This is how other drivers have already done it, and it haven't encountered problems in practice.
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/remote/remote_driver.c | 162 +++++++++++++++++--------------------------- 1 files changed, 62 insertions(+), 100 deletions(-)
The functionality change seems reasonable, and I didn't spot any problems in this patch. ACK.
The comments earlier in the series didn't seem difficult to resolve, but were probably enough to warrant posting a v2 once you've addressed them.
Thanks for the review, I pushed the first 2 patches and will respin the rest. - Cole