[libvirt] [PATCH 1/4] configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE

One of the advantages is that LIBVIRT_RESULT aligns the resulting message for us. The other is that in near future we will colour some parts of the message and thus it helps if we get arguments split in two. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- configure.ac | 8 ++++---- m4/virt-chrdev-lock-files.m4 | 2 +- m4/virt-debug.m4 | 2 +- m4/virt-default-editor.m4 | 2 +- m4/virt-dtrace.m4 | 2 +- m4/virt-host-validate.m4 | 2 +- m4/virt-init-script.m4 | 2 +- m4/virt-loader-nvram.m4 | 2 +- m4/virt-login-shell.m4 | 2 +- m4/virt-numad.m4 | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/configure.ac b/configure.ac index bf9e7681bc..a8f8b0517e 100644 --- a/configure.ac +++ b/configure.ac @@ -1047,14 +1047,14 @@ LIBVIRT_WIN_RESULT_WINDRES AC_MSG_NOTICE([]) AC_MSG_NOTICE([Test suite]) AC_MSG_NOTICE([]) -AC_MSG_NOTICE([ Coverage: $enable_test_coverage]) -AC_MSG_NOTICE([ Alloc OOM: $enable_test_oom]) +LIBVIRT_RESULT([Coverage], [$enable_test_coverage]) +LIBVIRT_RESULT([Alloc OOM], [$enable_test_oom]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Miscellaneous]) AC_MSG_NOTICE([]) LIBVIRT_RESULT_DEBUG -AC_MSG_NOTICE([ Use -Werror: $enable_werror]) -AC_MSG_NOTICE([ Warning Flags: $WARN_CFLAGS]) +LIBVIRT_RESULT([Use -Werror], [$enable_werror]) +LIBVIRT_RESULT([Warning Flags], [$WARN_CFLAGS]) LIBVIRT_RESULT_DTRACE LIBVIRT_RESULT_NUMAD LIBVIRT_RESULT_INIT_SCRIPT diff --git a/m4/virt-chrdev-lock-files.m4 b/m4/virt-chrdev-lock-files.m4 index 7d85c0e21b..5802136b9f 100644 --- a/m4/virt-chrdev-lock-files.m4 +++ b/m4/virt-chrdev-lock-files.m4 @@ -48,5 +48,5 @@ AC_DEFUN([LIBVIRT_CHECK_CHRDEV_LOCK_FILES], [ ]) AC_DEFUN([LIBVIRT_RESULT_CHRDEV_LOCK_FILES], [ - AC_MSG_NOTICE([ Char device locks: $with_chrdev_lock_files]) + LIBVIRT_RESULT([Char device locks], [$with_chrdev_lock_files]) ]) diff --git a/m4/virt-debug.m4 b/m4/virt-debug.m4 index d03cf10255..d3ac0564f2 100644 --- a/m4/virt-debug.m4 +++ b/m4/virt-debug.m4 @@ -29,5 +29,5 @@ AC_DEFUN([LIBVIRT_CHECK_DEBUG], [ ]) AC_DEFUN([LIBVIRT_RESULT_DEBUG], [ - AC_MSG_NOTICE([ Debug: $enable_debug]) + LIBVIRT_RESULT([Debug], [$enable_debug]) ]) diff --git a/m4/virt-default-editor.m4 b/m4/virt-default-editor.m4 index 0c8e1e0798..4b4cad4e87 100644 --- a/m4/virt-default-editor.m4 +++ b/m4/virt-default-editor.m4 @@ -28,5 +28,5 @@ AC_DEFUN([LIBVIRT_CHECK_DEFAULT_EDITOR], [ ]) AC_DEFUN([LIBVIRT_RESULT_DEFAULT_EDITOR], [ - AC_MSG_NOTICE([ Default Editor: $with_default_editor]) + LIBVIRT_RESULT([Default Editor], [$with_default_editor]) ]) diff --git a/m4/virt-dtrace.m4 b/m4/virt-dtrace.m4 index e072b639cd..3dc20d5343 100644 --- a/m4/virt-dtrace.m4 +++ b/m4/virt-dtrace.m4 @@ -41,5 +41,5 @@ AC_DEFUN([LIBVIRT_CHECK_DTRACE], [ ]) AC_DEFUN([LIBVIRT_RESULT_DTRACE], [ - AC_MSG_NOTICE([ DTrace: $with_dtrace]) + LIBVIRT_RESULT([DTrace], [$with_dtrace]) ]) diff --git a/m4/virt-host-validate.m4 b/m4/virt-host-validate.m4 index 643cd8f06e..e43cec5366 100644 --- a/m4/virt-host-validate.m4 +++ b/m4/virt-host-validate.m4 @@ -39,5 +39,5 @@ AC_DEFUN([LIBVIRT_CHECK_HOST_VALIDATE], [ ]) AC_DEFUN([LIBVIRT_RESULT_HOST_VALIDATE], [ - AC_MSG_NOTICE([virt-host-validate: $with_host_validate]) + LIBVIRT_RESULT([virt-host-validate], [$with_host_validate]) ]) diff --git a/m4/virt-init-script.m4 b/m4/virt-init-script.m4 index 91bbd68235..6eb81f0429 100644 --- a/m4/virt-init-script.m4 +++ b/m4/virt-init-script.m4 @@ -51,5 +51,5 @@ AC_DEFUN([LIBVIRT_CHECK_INIT_SCRIPT],[ ]) AC_DEFUN([LIBVIRT_RESULT_INIT_SCRIPT],[ - AC_MSG_NOTICE([ Init script: $with_init_script]) + LIBVIRT_RESULT([Init script], [$with_init_script]) ]) diff --git a/m4/virt-loader-nvram.m4 b/m4/virt-loader-nvram.m4 index 0eb77fa923..d7e0c8ca18 100644 --- a/m4/virt-loader-nvram.m4 +++ b/m4/virt-loader-nvram.m4 @@ -37,5 +37,5 @@ AC_DEFUN([LIBVIRT_CHECK_LOADER_NVRAM], [ ]) AC_DEFUN([LIBVIRT_RESULT_LOADER_NVRAM], [ - AC_MSG_NOTICE([ Loader/NVRAM: $with_loader_nvram]) + LIBVIRT_RESULT([Loader/NVRAM], [$with_loader_nvram]) ]) diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index 3baec5432f..713c488599 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -39,5 +39,5 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ ]) AC_DEFUN([LIBVIRT_RESULT_LOGIN_SHELL], [ - AC_MSG_NOTICE([ virt-login-shell: $with_login_shell]) + LIBVIRT_RESULT([virt-login-shell], [$with_login_shell]) ]) diff --git a/m4/virt-numad.m4 b/m4/virt-numad.m4 index e760dcc579..378eba3c97 100644 --- a/m4/virt-numad.m4 +++ b/m4/virt-numad.m4 @@ -54,5 +54,5 @@ AC_DEFUN([LIBVIRT_CHECK_NUMAD], [ ]) AC_DEFUN([LIBVIRT_RESULT_NUMAD], [ - AC_MSG_NOTICE([ numad: $with_numad]) + LIBVIRT_RESULT([numad], [$with_numad]) ]) -- 2.21.0