Re: [libvirt] PATCH: Switch openvz driver to domain APIs
On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote:
>> The biggest flaw I see currently is that the
>> openvz driver doesn't load the existing device config for networks or
>> filesystems of existing VMs, so you can't see that info in the XML dump
> Yes. Good note. I will implement it.
>> - /*get VCPU*/
>> - ret = openvzReadConfigParam(veid, "CPUS", temp,
sizeof(temp));
>> - if (ret < 0) {
>> - openvzError(conn, VIR_ERR_INTERNAL_ERROR,
>> - _("Cound not read config for container
%d"),
>> veid);
>> - goto error;
>> - } else if (ret > 0) {
>> - vmdef->vcpus = strtoI(temp);
>> - }
> Why did you remove loading VCPUs and always set = 1 ?
Stupid mistake during a manual merge. Here's an updated patch which
fixes that mistake
The patch looks good now.
Daniel