On 04/11/2013 08:35 AM, harryxiyou@gmail.com wrote:
From: Harry Wei <harryxiyou@gmail.com>
virCommandNewArgList may return NULL so we need not do following stuffs and just return '-1'.
Signed-off-by: Harry Wei <harryxiyou@gmail.com> CC: Osier Yang <jyang@redhat.com> CC: Michal Privoznik <mprivozn@redhat.com> --- src/storage/storage_backend_sheepdog.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index 35a3a04..3452eaa 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -120,6 +120,8 @@ virStorageBackendSheepdogRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED, virCommandPtr cmd;
cmd = virCommandNewArgList(COLLIE, "node", "info", "-r", NULL); + if (cmd == NULL) + return -1;
NACK. virCommand is explicitly designed to allow NULL input on all intermediate commands, and finally report the error at virCommandRun() time, without burdening the caller with intermediate error checking. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org