On 11/07/2014 05:53 PM, Eric Blake wrote:
On 11/07/2014 10:35 AM, Luyao Huang wrote:
From virAccessDriverPolkitCheckInterface function, we know this attribute should named: interface_macaddr Eww. 'git am' strips an initial commit line beginning with ">From ", if it doesn't match an email address (this is because it special cases a leading 'From: ...' or '>From: ...' line as overriding commit authorship instead of using the email's sender as the author). I didn't realize
On 11/07/2014 10:47 AM, Eric Blake wrote: that I lost a line of your commit message until after I had pushed my modifications.
In the future, try to avoid using "From" as the first word of a commit message. "Based on the" could serve as an appropriate substitute phrase for this case. So interesting :) i didn't notice this before.I will change my word next time, thanks your advice.