On 06/20/2011 08:45 PM, Daniel Veillard wrote:
On Mon, Jun 20, 2011 at 03:34:07PM -0400, Cole Robinson wrote:
On 06/19/2011 09:45 PM, Daniel Veillard wrote:
On Wed, Jun 15, 2011 at 09:23:19PM -0400, Cole Robinson wrote:
These functions aren't intended to be called directly by users, so mark them as private.
Hum, should that be one _ or two __ ? But ACK to cleanup !
Python convention is anything starting with an underscore is considered private. It only attempts to enforce this if using double underscore in the name of a class method/attribute, which causes some auto name mangling. However since these aren't class methods, double vs. single underscore isn't any different.
Okay, thanks for the explanations, I remembered we used __ a long time ago, and wasn't sure :-)
Thanks, pushed V2 of this series (since all patches either didn't change or the new versions were ACKd) - Cole