16 Oct
2012
16 Oct
'12
9:53 a.m.
On 10/16/2012 11:50 AM, Daniel P. Berrange wrote:
On Tue, Oct 16, 2012 at 11:19:55AM +0200, Martin Kletzander wrote:
There was a crash possible when both <boot dev... and <boot order... were specified due to virDomainDefParseBootXML() erroring out before setting *tmp (which was free'd in cleanup). As a fix, I created this cleanup that uses one pointer for all the temporary stored XPath strings and values, plus this pointer is correctly initialized to NULL. --- src/conf/domain_conf.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
It would be nice to have a test to check for this scenario
Daniel
Good point, patch follows. Martin