Re: [libvirt] [PATCH 00/12] Drop KVM assignment

On Tue, Aug 20, 2019 at 02:53:32PM -0300, Daniel Henrique Barboza wrote: > > > On 8/20/19 11:30 AM, Michal Privoznik wrote: >> The KVM style of PCI assignment is not used, and it hasn't been for a >> while. Any attempt to start a domain with it would result in error as >> kernel dropped its support in 4.12.0 (after being deprecated for 1.5 >> years). > > LGTM. Just a comment in patch 01. > > > After applying the whole series I tried to find the remaining references > of 'pci-assign'. This is what git grep returns: > Yes, the 'kvm-pci-assign' device was present in those QEMU versions so it was listed in the replies. > > $ git grep 'pci-assign' > src/qemu/qemu_capabilities.h:    X_QEMU_CAPS_PCI_CONFIGFD, /* > pci-assign.configfd */ > src/qemu/qemu_capabilities.h:    X_QEMU_CAPS_PCI_BOOTINDEX, /* > pci-assign.bootindex */ > tests/qemucapabilitiesdata/caps_1.5.3.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_1.6.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_1.7.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.1.1.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.10.0.x86_64.replies: "name": > "kvm-pci-assign", > tests/qemucapabilitiesdata/caps_2.4.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.5.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.6.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.7.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.8.0.x86_64.replies: "name": > "kvm-pci-assign" > tests/qemucapabilitiesdata/caps_2.9.0.x86_64.replies: "name": > "kvm-pci-assign" > > > And with 'configfd': > > $ git grep 'configfd' > docs/news-2011.html.in:      qemu: simplify PCI configfd handling in > monitor (Eric Blake),<br/> > src/qemu/qemu_capabilities.c:              "pci-configfd", > src/qemu/qemu_capabilities.h:    X_QEMU_CAPS_PCI_CONFIGFD, /* > pci-assign.configfd */ > tests/qemustatusxml2xmldata/migration-in-params-in.xml: <flag > name='pci-configfd'/> > tests/qemustatusxml2xmldata/migration-out-params-in.xml: <flag > name='pci-configfd'/> > > > > Do we still need X_QEMU_CAPS_PCI_CONFIGFD and X_QEMU_CAPS_PCI_BOOTINDEX > after this series? > We need to be capable of parsing the qemu capability flags produced by older libvirt even though we aren't taking them into account. When upgrading libvirt while a domain is running, or migrating to a host with newer libvirt, rejecting the capability might break existing guests even though they did not use that particular capability. So we keep it around with an X- prefix and the corresponding string representation unchanged and just quietly ignore it.

Jano