Re: [libvirt] [PATCH v2 9/9] pci: Add debug messages when unbinding from stub driver
On Tue, 2016-01-26 at 19:00 -0500, John Ferlan wrote:
> - VIR_DEBUG("Found stub driver %s", driver);
> + VIR_DEBUG("Found stub driver %s for PCI device %s", driver,
dev->name);
> + VIR_DEBUG("Unbinding PCI device %s", dev->name);
Redundant - How about "Found stub driver %s to unbind PCI device %s" or
"Unbinding PCI device %s for stub driver %s" (don't forget to change
order of args ;-))
IOW: No need to have two messages.
What about "Unbinding PCI device %s (stub driver %s)"?
Hope they help some day!
They have certainly helped me while working on the rest of the
series ;)
I've tried to reply to each of your comments exactly once, please let me
know if I've missed any in the process. Thanks again for taking the time
to look at this.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team