Re: [libvirt] [PATCH 00/12] qemu: Refactor block stats gathering and implement summary stats

On Tue, Mar 10, 2015 at 05:26:29PM +0100, Peter Krempa wrote: > Peter Krempa (12): > qemu: Use macro to set block stats typed parameters > qemu: monitor: Drop parsing of 'errs' from block info > qemu: blockstats: Switch to caller allocated hash table > test: qemu: Fix qemu monitor test utils to allow testing HMP > qemu: monitor: Implement HMP version for listing all block device > stats > qemu: monitor: Convert common code to a macro > qemu: monitor: Count block stats fields in > qemuMonitorGetAllBlockStatsInfo > qemu: Split out working code qemuDomainBlockStats > qemu: blockstats: Add support for totalled block statistics > qemu: blockstats: Refactor qemuDomainBlockStatsFlags > test: qemu: json: Avoid using the now obsolete functions > qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber) > > src/qemu/qemu_driver.c | 299 ++++++++++++++++++++----------------------- > src/qemu/qemu_monitor.c | 106 ++++++--------- > src/qemu/qemu_monitor.h | 15 --- > src/qemu/qemu_monitor_json.c | 233 ++++----------------------------- > src/qemu/qemu_monitor_json.h | 15 +-- > src/qemu/qemu_monitor_text.c | 256 ++++++++++++++---------------------- > src/qemu/qemu_monitor_text.h | 16 +-- > tests/Makefile.am | 8 +- > tests/qemumonitorjsontest.c | 65 ++++------ > tests/qemumonitortest.c | 89 ++++++++++++- > tests/qemumonitortestutils.c | 3 +- > tools/virsh.pod | 5 +- > 12 files changed, 425 insertions(+), 685 deletions(-) ACK series.

Did you just add a feature while removing 260 lines of code?

Jan