Re: [libvirt] [PATCH] (qemuTeardownDiskCgroup): avoid dead code

Eric Blake wrote: > On 05/17/2010 02:52 PM, Jim Meyering wrote: >> It's a good thing the latter while loop condition >> could never be true -- otherwise it'd be an infloop. >> >> char *path = disk->src; >> int ret = -1; >> >> - while (path != NULL) { >> + do { >> virStorageFileMetadata meta; >> int rc; >> >> VIR_DEBUG("Process path %s for disk", path); > ... >> path = meta.backingStore; >> } while (path != NULL); > > Are we sure disk->src is guaranteed to be non-NULL on entry, or would > have been better to rewrite this as while{}/*nothing*/ instead of do{}while? You're right. disk->src may be NULL, as attested by surrounding code that tests for it via NULLSTR upon failure of these functions. Thanks! Here's a better patch: