Re: [libvirt] [PATCH] Fix locking in virsh console

Daniel P. Berrange wrote:

On Mon, Mar 10, 2014 at 03:04:15PM +0400, Roman Bogorodskiy wrote:

...

vshRunConsole() uses virCondWait() which is a wrapper around pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be locked, otherwise it immediately fails with EPERM. On Linux, the behaviour in this case is undefined.

So lock the mutex before calling virCondWait(). --- tools/virsh-console.c | 5 +++++ 1 file changed, 5 insertions(+)

ACK

Pushed, thanks! Roman Bogorodskiy