Re: [libvirt] [PATCH] storage: expose volume meta-type in XML

On Fri, Nov 22, 2013 at 03:26:11PM -0700, Eric Blake wrote: > I got annoyed at having to use both 'virsh vol-list $pool --details' > AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated > the volume correctly. Since two-thirds of the data present in > virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(), > this just adds the remaining piece of information. > > * docs/formatstorage.html.in: Document new <target type=...>. > * docs/schemas/storagevol.rng (target, backingStore): Add it to > RelaxNG. > * src/conf/storage_conf.h (virStorageVolTypeToString): Declare. > * src/conf/storage_conf.c (virStorageVolTargetDefFormat): Output > the metatype. > * tests/storagevolxml2xmlout/vol-*.xml: Update tests to match. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > ---

I think I'd be more inclined to have a top level attribute eg <volume type=block>