On 06/06/2011 04:48 AM, Michal Prívozník wrote:
From: Michal Privoznik <mprivozn@redhat.com>
This option accepts 3 values: -keep, to keep current client connected (Spice+VNC) -disconnect, to disconnect client (Spice) -fail, to fail setting password if there is a client connected (Spice) --- diff to v1: -Eric's review suggestions included -update 'Since'
@@ -1797,16 +1802,20 @@ qemuDomainChangeGraphicsPasswords(struct qemud_driver *driver, qemuDomainObjPrivatePtr priv = vm->privateData; time_t now = time(NULL); char expire_time [64]; + const char *connected; int ret;
if (!auth->passwd && !driver->vncPassword) return 0;
+ if (auth->connected) + connected = virDomainGraphicsAuthConnectedTypeToString(auth->connected)l
This can't have compiled. s/l$/;/ The rest of the patch looks good, but we're still missing some testsuite exposure to ensure we don't regress in the future. I'd feel better with a v3 that also adds a test case in tests/qemuxml2argvdata that exercises the new attribute. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org