On Fri, Sep 19, 2025 at 11:27:06AM +0200, Peter Krempa wrote:
On Tue, Aug 19, 2025 at 18:22:33 +0200, Andrea Bolognani via Devel wrote:
if (ARCH_IS_LOONGARCH(def->os.arch) || + qemuDomainIsARMVirt(def) || qemuDomainIsRISCVVirt(def)) { /* Use USB3 for modern architectures */ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI))
I agree with using the same code as long as it doesn't require the NEC controller in the fallback path. If the aarch virt machine requires it, have a separate branch for it, but adding a pointless fallback to other arches doesn't make it worth.
Okay, I don't feel very strongly about it. It just made the code a bit shorter, but in practice there is basically no scenario in which nec-xhci is available but qemu-xhci isn't so I'm fine with leaving out that fallback option. -- Andrea Bolognani / Red Hat / Virtualization