Re: [libvirt] [PATCH 3/5] util: Introduce virFileMoveMount
On 01/30/2017 10:14 PM, Olaf Hering wrote:
On Wed, Jan 11, Michal Privoznik wrote:
> This is a simple wrapper over mount(). However, not every system
> out there is capable of moving a mount point. Therefore, instead
> of having to deal with this fact in all the places of our code we
> can have a simple wrapper and deal with this fact at just one
> place.
> +++ b/src/util/virfile.c
> + const unsigned long mount_flags = MS_MOVE;
This fails to compile on systems without MS_MOVE, like openSUSE 11.4.
configure checks all sorts of things, perhaps it should detect the
presence of MS_MOVE as well and do the appropriate action.
[ 306s] util/virfile.c:3618:39: error: 'MS_MOVE' undeclared (first use in this
function)
Olaf
Ah, have you tried with the latest git HEAD? BTW: looking at wiki, isn't
openSUSE 11.4 out of life? It has kernel 2.6.34 which is quite old. But
looking into kernel's git log the symbol was introduced in the very
first commit (import from CVS, I did not bother to search that can of
worms). Anyway, this is 2.6.12 that we are talking about. I wonder
whether SUSE is doing some magic over the linux header files that
removes the symbol? Does the following command find anything?
$ grep -r MS_MOVE /usr/include/
Michal